Open
Conversation
…, also put some comments in the code
intii
approved these changes
Nov 2, 2018
intii
left a comment
intii
left a comment
There was a problem hiding this comment.
En general está muy bien. Dos cosas:
-
El ejercicio del Logger está mal. Estás haciendo que EventEmitter extienda de Logger, cuando no deberían conocerse. La idea era que pudieras crear un objeto Logger, y pudieras suscribirlo a una Movie para que loggeara algún evento.
-
Fijate que en el PR, aparecen todos los commits del Topic anterior, eso está mal. Creaste el branch seguramente a partir del branch del topic 1, cuando debería ser a partir de
master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.